Implement a model of twilight sky brightness #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update on the two issues mentioned earlier:
Three new plots to document the new model (which are now in the docs, along with instructions to reproduce them):
|
|
You'll want to bring in the latest changes from master to get tests to pass. |
|
@dkirkby It would be very helpful to have this updated sky model implemented to carry out some bright-time redshift success tests, even if there's still work to be done. Can you provide any updates on when we might be able to merge this? Thanks! |
|
Any chance of getting these changes into the 18.12 software release? |
|
@dkirkby, this PR is now about 3 years old. Should we continue to keep this open? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have a functional twilight model that can be used together with the scattered moon model for more realistic bright-time simulations. The two main questions I would like to follow up on eventually are:
However, I think the general features of this model are a big improvement over nothing so should be merged soon unless anyone spots obvious problems.
This PR also removes the (now obsolete)
sky-conditionsconfig parameter, which was originally to support using the gray/bright spectra in desimodel but is now redundant with the more flexible moon and twilight models.